Skip to content
This repository was archived by the owner on May 24, 2026. It is now read-only.

Tighten the v1.1.0 commercial example suite#15

Merged
GsCommand merged 1 commit into
mainfrom
codex/clean-and-validate-v1.1.0-example-suite
Mar 19, 2026
Merged

Tighten the v1.1.0 commercial example suite#15
GsCommand merged 1 commit into
mainfrom
codex/clean-and-validate-v1.1.0-example-suite

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • Repair and complete the v1.1.0 commercial example suite so the set is clean, protocol-grade, and safe to merge.
  • Ensure each invalid example isolates a single schema failure and each verb has broadened valid coverage demonstrating allowed alternative states.

Description

  • Fixed malformed / ambiguous examples and tightened payloads across authorize, checkout, purchase, ship, and verify so every changed JSON file is syntactically valid and uses canonical v1.1.0 vocabulary.
  • Added one materially different valid receipt per verb to broaden coverage (denied/pending/in-transit/inconclusive states) and created corresponding files under examples/v1.1.0/commercial/*/valid/901-*.json.
  • Revised invalid examples so each now fails for exactly one intended reason (e.g., wrong money type, empty items, zero quantity, unsupported commercial_ref.type, missing conditional payment_proof/approved_until/delivery_proof_ref/reason).
  • Regenerated checksums.txt to include the expanded example inventory and committed all changed example files and checksums.

Testing

  • Ran duplicate-key JSON sanity check with Python: json.load(..., object_pairs_hook=no_dups) against examples/v1.1.0/commercial and it completed without errors.
  • Ran example validation: npm run validate:examples and full validation: npm run validate which both completed successfully and reported all current-line examples validated.
  • Regenerated checksums with npm run generate:checksums and validated integrity via npm run validate where integrity validation passed after the update.
  • Confirmed that all modified valid examples pass and all invalid examples fail for their single intended schema reason when validated with AJV.

Codex Task

@GsCommand GsCommand merged commit ab9a666 into main Mar 19, 2026
1 check passed
@GsCommand GsCommand deleted the codex/clean-and-validate-v1.1.0-example-suite branch March 20, 2026 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant